-
Notifications
You must be signed in to change notification settings - Fork 173
cosmetic changes #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dschach
wants to merge
16
commits into
mitchspano:main
Choose a base branch
from
dschach:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
cosmetic changes #175
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
884a527
project files
dschach c1d8970
run prettier
dschach d5a9c21
add list views
dschach 4bcf28b
all fields SubscriberControlled
dschach ffcec92
add Bypass Execution to related list
dschach b95b253
include husky pre-commit
dschach e275ee9
Revert "run prettier"
dschach cf5eb0f
revert field control
dschach 8590727
remove some metadata
dschach 75d86c2
fix husky in package.json
dschach d866ce7
prettier Apex classes
dschach 46646d2
remove list views
dschach 4d02a09
field manageability reversion
dschach 0eb0b05
remove comment
dschach 1cf8e43
remove unnecessary filter
dschach 8ae56af
Update .prettierrc
dschach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
npm run precommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,69 @@ | ||
{ | ||
"plugins": ["prettier-plugin-apex"], | ||
"arrowParens": "avoid", | ||
"bracketSpacing": true, | ||
"bracketSameLine": true, | ||
"printWidth": 100, | ||
"semi": true, | ||
"singleQuote": true, | ||
"trailingComma": "none", | ||
"endOfLine": "lf", | ||
"apexInsertFinalNewline": false, | ||
"useTabs": true, | ||
"overrides": [ | ||
{ | ||
"files": "**/lwc/**/*.html", | ||
"options": { "parser": "lwc" } | ||
}, | ||
{ | ||
"files": "*.{cls,trigger}", | ||
"options": { "parser": "apex", "tabWidth": 2, "useTabs": true } | ||
}, | ||
{ | ||
"files": "*.{cmp,page,component}", | ||
"options": { "parser": "html" } | ||
"options": { | ||
"parser": "html", | ||
"useTabs": true, | ||
"htmlWhitespaceSensitivity": "css" | ||
} | ||
}, | ||
{ | ||
"files": "*.{apex,soql}", | ||
"options": { "parser": "apex-anonymous" } | ||
}, | ||
{ | ||
"files": "*.{yml,yaml}", | ||
"options": { "parser": "yaml", "tabWidth": 2, "useTabs": false } | ||
}, | ||
{ | ||
"files": ".prettier*", | ||
"options": { "parser": "json", "printWidth": 80, "useTabs": true } | ||
}, | ||
{ | ||
"files": "*.xml", | ||
"options": { | ||
"parser": "xml", | ||
"useTabs": true, | ||
"singleQuote": false, | ||
"xmlSelfClosingSpace": true | ||
} | ||
}, | ||
{ | ||
"files": "*meta.xml", | ||
"options": { | ||
"parser": "xml", | ||
"useTabs": false, | ||
"xmlSelfClosingSpace": false | ||
} | ||
}, | ||
{ | ||
"files": "*.json", | ||
"options": { | ||
"parser": "json-stringify", | ||
"useTabs": false, | ||
"tabWidth": 2 | ||
} | ||
} | ||
] | ||
], | ||
"plugins": ["prettier-plugin-apex", "@prettier/plugin-xml"], | ||
"$schema": "https://json.schemastore.org/prettierrc" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,4 +45,4 @@ | |
"Trigger Actions [email protected]": "04tKY000000PdZJYA0", | ||
"Trigger Actions [email protected]": "04tKY000000PdZOYA0" | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the source of all of this customization in this file?
The standard config is available here. I see advantage in specifying
apexInsertFinalNewline : false
, but the rest of the stuff seems to be the project-specific configuration from another team's project.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the file I use for my projects - it has more granular items from my experiences. For example, the space before the closing
/>
on the top line of metadata files now won't trigger a whitespace change if the metadata is downloaded from the org.