Add field to MMIOSpec for hardware guarantees #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft PR for bedrock2 changes: mit-plv/bedrock2#187 |
|
CI is failing, but it looks like master has the same error? |
|
If this works, it's cool, but I'm not yet sure if it will, can we wait with merging until I understand? |
| @@ -22,13 +22,15 @@ Require Import riscv.Platform.Sane. | |||
| Local Open Scope Z_scope. | |||
| Local Open Scope bool_scope. | |||
|
|
|||
|
|
|||
| Class MMIOSpec{W: Words} := { | |||
| Class MMIOSpec{W: Words} {Mem : map.map word byte} := { | |||
There was a problem hiding this comment.
I guess LogItem takes it as a parameter?
There was a problem hiding this comment.
I guess LogItem takes it as a parameter?
Yes, that's where it's used.
samuelgruetter
approved these changes
May 13, 2021
| @@ -22,13 +22,15 @@ Require Import riscv.Platform.Sane. | |||
| Local Open Scope Z_scope. | |||
| Local Open Scope bool_scope. | |||
|
|
|||
|
|
|||
| Class MMIOSpec{W: Words} := { | |||
| Class MMIOSpec{W: Words} {Mem : map.map word byte} := { | |||
There was a problem hiding this comment.
I guess LogItem takes it as a parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in mit-plv/bedrock2#186
I've been able to build bedrock2 on top of this change with a couple of slight modifications (I'll push a draft PR to bedrock2 in a second so you can view those).