Upload *.timing files on failure (#2012)

This may help with debugging #2009 (comment)
mit-plv · Feb 5, 2025 · 6f9b5df · 6f9b5df
1 parent f47be1a
commit 6f9b5df
Show file tree

Hide file tree

Showing 6 changed files with 63 additions and 10 deletions.
diff --git a/.github/workflows/coq-alpine.yml b/.github/workflows/coq-alpine.yml
@@ -80,13 +80,21 @@ jobs:
       shell: alpine.sh {0}
       run: etc/ci/github-actions-make.sh -j2 generated-files
     - run: tar -czvf generated-files.tgz fiat-*/
-      if: ${{ failure() }}
+      if: failure()
     - name: upload generated files
       uses: actions/upload-artifact@v4
       with:
         name: generated-files-${{ matrix.alpine }}
         path: generated-files.tgz
-      if: ${{ failure() }}
+      if: failure()
+    - run: find . -name "*.timing" | xargs tar -czvf timing-files.tgz
+      if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-${{ matrix.alpine }}
+        path: timing-files.tgz
+      if: failure()
     - name: standalone-haskell
       shell: alpine.sh {0}
       run: etc/ci/github-actions-make.sh -j1 standalone-haskell GHCFLAGS='+RTS -M7G -RTS'

diff --git a/.github/workflows/coq-archlinux.yml b/.github/workflows/coq-archlinux.yml
@@ -45,13 +45,21 @@ jobs:
     - name: generated-files
       run: etc/ci/github-actions-make.sh -j2 generated-files
     - run: tar -czvf generated-files.tgz fiat-*/
-      if: ${{ failure() }}
+      if: failure()
     - name: upload generated files
       uses: actions/upload-artifact@v4
       with:
         name: generated-files-archlinux
         path: generated-files.tgz
-      if: ${{ failure() }}
+      if: failure()
+    - run: find . -name "*.timing" | xargs tar -czvf timing-files.tgz
+      if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-archlinux
+        path: timing-files.tgz
+      if: failure()
     - name: install-standalone-unified-ocaml
       run: etc/ci/github-actions-make.sh install-standalone-unified-ocaml BINDIR=dist
     #- name: standalone-js-of-ocaml

diff --git a/.github/workflows/coq-debian.yml b/.github/workflows/coq-debian.yml
@@ -50,13 +50,21 @@ jobs:
     - name: generated-files
       run: etc/ci/github-actions-make.sh -j2 generated-files
     - run: tar -czvf generated-files.tgz fiat-*/
-      if: ${{ failure() }}
+      if: failure()
     - name: upload generated files
       uses: actions/upload-artifact@v4
       with:
         name: generated-files-${{ matrix.debian }}
         path: generated-files.tgz
-      if: ${{ failure() }}
+      if: failure()
+    - run: find . -name "*.timing" | xargs tar -czvf timing-files.tgz
+      if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-${{ matrix.debian }}
+        path: timing-files.tgz
+      if: failure()
     - name: install-standalone-unified-ocaml
       run: etc/ci/github-actions-make.sh install-standalone-unified-ocaml BINDIR=dist
     - name: standalone-js-of-ocaml

diff --git a/.github/workflows/coq-docker.yml b/.github/workflows/coq-docker.yml
@@ -98,6 +98,14 @@ jobs:
       with:
         name: build-outputs-docker-coq-${{ matrix.env.DOCKER_COQ_VERSION }}-ocaml-${{ matrix.env.DOCKER_OCAML_VERSION }}
         path: fiat-crypto-build.tar.gz
+    - run: find . -name "*.timing" | xargs tar -czvf timing-files.tgz
+      if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-${{ matrix.env.COQ_VERSION }}
+        path: timing-files.tgz
+      if: failure()
     - name: install
       uses: coq-community/docker-coq-action@v1
       with:
@@ -371,13 +379,13 @@ jobs:
       run: etc/ci/github-actions-make.sh --warnings -f Makefile.examples -j2 generated-files
       if: github.event_name == 'pull_request'
     - run: tar -czvf generated-files.tgz fiat-*/
-      if: ${{ failure() }}
+      if: failure()
     - name: upload generated files
       uses: actions/upload-artifact@v4
       with:
         name: generated-files-${{ matrix.coq-version }}
         path: generated-files.tgz
-      if: ${{ failure() }}
+      if: failure()
 
   standalone-haskell:
     needs: build

diff --git a/.github/workflows/coq-macos.yml b/.github/workflows/coq-macos.yml
@@ -73,6 +73,14 @@ jobs:
       run: opam exec -- etc/ci/github-actions-make.sh -j2 all
       if: ${{ matrix.os.arch != 'arm64' }}
       # js_of_ocaml is too heavy for M1 GH Action runners which have only 7GB RAM, cf https://github.com/ocsigen/js_of_ocaml/issues/1612, https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories
+    - run: find . -name "*.timing" | xargs tar -czvf timing-files.tgz
+      if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-${{ matrix.os.runs-on }}
+        path: timing-files.tgz
+      if: failure()
     - name: install-standalone-unified-ocaml
       run: opam exec -- etc/ci/github-actions-make.sh install-standalone-unified-ocaml BINDIR=dist
     - name: install-standalone-js-of-ocaml

diff --git a/.github/workflows/coq-windows.yml b/.github/workflows/coq-windows.yml
@@ -44,10 +44,10 @@ jobs:
       uses: ocaml/setup-ocaml@v3
       with:
         ocaml-compiler: 4.13.1
-    - run: opam pin add ocamlfind 'git+https://github.com/ocaml/ocamlfind.git#master'
+    - run: opam install conf-time conf-gcc
+    - run: opam install 'ocamlfind>=1.9.7'
     - run: opam pin add --kind=version coq ${{ env.COQ_VERSION }}
     - run: opam install js_of_ocaml
-    - run: opam install conf-time conf-gcc
     - name: Work around https://github.com/actions/checkout/issues/766
       run: opam exec -- bash -l -c 'git config --global --add safe.directory "*"'
     - name: echo build params
@@ -71,6 +71,19 @@ jobs:
       run: opam exec -- bash etc/ci/github-actions-make.sh -j${{ env.NJOBS }} c-files lite-generated-files
     - name: only-test-amd64-files-lite
       run: opam exec -- bash etc/ci/github-actions-make.sh -j${{ env.NJOBS }} only-test-amd64-files-lite SLOWEST_FIRST=1
+    - name: aggregate timing files for upload
+      run: |
+        $files = Get-ChildItem -Path . -Filter "*.timing" -Recurse
+        $files | ForEach-Object { Write-Output "Adding: $_" }
+        $files | Compress-Archive -DestinationPath timing-files.zip -Force
+      shell: pwsh
+      # if: failure()
+    - name: upload generated timing files
+      uses: actions/upload-artifact@v4
+      with:
+        name: timing-files-windows
+        path: timing-files.zip
+      if: failure()
     - name: upload OCaml files
       uses: actions/upload-artifact@v4
       with: