Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps/coqutil from 0833256 to e395373 #438

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

Bumps deps/coqutil from 0833256 to e395373.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [deps/coqutil](https://github.com/mit-plv/coqutil) from `0833256` to `e395373`.
- [Release notes](https://github.com/mit-plv/coqutil/releases)
- [Commits](mit-plv/coqutil@0833256...e395373)

---
updated-dependencies:
- dependency-name: deps/coqutil
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the submodules label Dec 9, 2024
@github-actions github-actions bot enabled auto-merge (squash) December 9, 2024 05:30
@ppedrot
Copy link
Contributor

ppedrot commented Dec 10, 2024

Can somebody take care of this PR swiftly, it's needed for the Coq CI to go through.

@samuelgruetter samuelgruetter merged commit 3a127a4 into master Dec 10, 2024
2 of 4 checks passed
@dependabot dependabot bot deleted the dependabot/submodules/deps/coqutil-e395373 branch December 10, 2024 11:04
@samuelgruetter
Copy link
Contributor

Usually these dependabot PRs would get automerged if our CI passes, but here our CI for Coq master didn't pass. I'm assuming that this is because Coq's CI currently is failing as well, and that our CI should work again once Coq's does?

@ppedrot
Copy link
Contributor

ppedrot commented Dec 10, 2024

Hopefully?

@JasonGross
Copy link
Contributor

JasonGross commented Dec 10, 2024

I'm assuming that this is because Coq's CI currently is failing as well, and that our CI should work again once Coq's does?

No, this is because the Ubuntu packages no longer build because dune build -p coq-core,coq-stdlib,coqide-server,coqide --display=verbose now fails with "Error: I don't know about package coq-stdlib (passed through --only-packages)". I don't have time to fix this right now, but if someone else can suggest what needs to change as a result of coq/coq#19530 (cc @proux01) I'm happy to merge PRs. (Alternatively / additionally, bedrock2 can switch to using docker for master.)

@proux01
Copy link
Contributor

proux01 commented Dec 10, 2024

You can take inspiration of the core-dev opam package https://github.com/coq/opam/blob/master/core-dev/packages/coq-stdlib/coq-stdlib.dev/opam
But indeed, using the docker image is probably more robust for dev.

@SkySkimmer
Copy link
Contributor

SkySkimmer commented Dec 10, 2024

I guess you can cd stdlib; dune build -p coq-stdlib separately from the other packages
not sure about the rest of the script

@SkySkimmer
Copy link
Contributor

@samuelgruetter can you bump rupicola in fiat-crypto too?

@samuelgruetter
Copy link
Contributor

@samuelgruetter can you bump rupicola in fiat-crypto too?

I manually triggered fiat-crypto's dependabot and it's building... mit-plv/fiat-crypto#1995

@samuelgruetter
Copy link
Contributor

@samuelgruetter can you bump rupicola in fiat-crypto too?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants