Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/coq/coq/pull/19149 #424

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Jun 10, 2024

Adapt to coq/coq#19149 this is backward compatible and can be merged right away.

@samuelgruetter samuelgruetter merged commit 3fe0e22 into mit-plv:master Jun 10, 2024
4 checks passed
@samuelgruetter
Copy link
Contributor

A note for future reference: Before merging this PR, .* */ // was already at level 0 (according to Print Grammar constr in Coq 8.19.1), so I expect that merging it should make no difference.
The .* */ x notation for funspecs, however, is at level 200. Putting both of them at level 200 does not work. Putting both of them at level 0 seems to work and might be desirable if there's a requirement to put both at the same level.

@proux01 proux01 deleted the coq_19149 branch June 10, 2024 15:40
@proux01
Copy link
Contributor Author

proux01 commented Jun 10, 2024

Currently not having them at the same level only generates a warning. It may become more problematic the day we'll remove the recovery thing in camlp5 (but we are not there yet).

@proux01
Copy link
Contributor Author

proux01 commented Jun 10, 2024

BTW, in what time frame can we expect the rupicola and fiat-crypto submodules to be updated nowadays?

@samuelgruetter
Copy link
Contributor

BTW, in what time frame can we expect the rupicola and fiat-crypto submodules to be updated nowadays?

We recently set up automerge for successful dependabot PRs, which run nightly, so if it all works, this change should be in fiat-crypto by tomorrow, without requiring any further manual action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants