Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/coq/coq/pull/18880 #415

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

proux01
Copy link
Contributor

@proux01 proux01 commented Apr 11, 2024

Adapt to coq/coq#18880

We should implement the nice suggestion of @andres-erbsen coq/coq#18880 (comment) to save the Existing Instance but meanwhile, this is probably good enough for now.

@andres-erbsen andres-erbsen enabled auto-merge (squash) April 11, 2024 15:27
@andres-erbsen andres-erbsen merged commit 15b0b22 into mit-plv:master Apr 11, 2024
2 checks passed
@proux01
Copy link
Contributor Author

proux01 commented Apr 11, 2024

Thanks

@proux01 proux01 deleted the coq_18880 branch April 11, 2024 18:53
@proux01
Copy link
Contributor Author

proux01 commented Apr 12, 2024

@andres-erbsen Out of curiosity, how/when is that expected to be updated in the fiat-crypto submodule?

@JasonGross
Copy link
Contributor

If mit-plv/rupicola#110 is merged then dependabot will create a PR in rupicola within a day, otherwise a maintainer needs to trigger dependabot manually (I don't have the bits to do this). Once the PR in rupicola is merged, dependabot will create a PR in Fiat Crypto within a day (or you can ping me and I can trigger it sooner), and then I can set that PR to merge once CI passes (generally a couple hours).

Note that with coq/coq#18736, even though this PR is merged, you can set up an overlay bedrock2 https://github.com/mit-plv/bedrock2 master $PR_NUMBER and not have the Coq PR blocked on submodule updates.

@proux01
Copy link
Contributor Author

proux01 commented Apr 12, 2024

Thanks for the explanation (and indeed, monthly really looks pretty slow, particularly if the is another month in fiat-crypto itself)

Note that with coq/coq#18736, even though this PR is merged, you can set up an overlay bedrock2 https://github.com/mit-plv/bedrock2 master $PR_NUMBER and not have the Coq PR blocked on submodule updates.

I was hoping to save the overlay, but I guess I won't escape it ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants