Feature/usys transition #279
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The whole xv6 is written in c and assembly. So why using a perl script to create the user/usys.S file. This commit will create a new helper tools/usys.c and also moves the helper mkfs/mkfs.c to tools/mkfs.c. The Makefile is updated to reflect this changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xv6 is written in c and assembly. So why using a perl script to create the user/usys.S file?
A a new helper tools/usys.c will replace user/usys.pl.
The helper mkfs/mkfs.c will be moved to tools/mkfs.c, so all helpers with are needed in the build process are in one location.
The Makefile is updated to reflect this changes.
tools/usys.c will create usys.S based on the definitions in kernel/syscall.h, no need to update usys.c for new syscalls.
I did a red/green test to see if the usys.S files contains everything (Due to the way it is generated in usys.pl the order is a bit different).
I would appreciate if this change could be merged.