Pass device to Hamiltonian, pass to pauli_string_to_matrix #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pauli_string_to_matrix
takes a device argument, which defaults totorch.device('cpu')
:torchquantum/torchquantum/util/utils.py
Line 990 in 611cc2a
When trying to use
Hamiltonian
on GPU this invariably leads to device errors, since the result frompauli_string_to_matrix
will be on CPU, so it would be nice to be able to pass device to Hamiltonian, which passes it on topauli_string_to_matrix
. Setting the default toNone
ensures that not previous behaviour is changed.