QCBM algorithm #271
Merged
QCBM algorithm #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GenericP3rson Can you help me with this |
|
Hi, don’t worry about getting that working, you just need to pass the functional tests! |
01110011011101010110010001101111
requested changes
Jun 2, 2024
01110011011101010110010001101111
requested changes
Jun 6, 2024
There was a problem hiding this comment.
Great work! A few last minor changes. If you could just keep the tabbing consistent in the qcbm.py file, that would be great! (A few examples are suggested—note that there might be some oddities with the spaces converting properly into tabs. I think it would be most optimal to just double-check that everything is consistent in the file itself.)
Co-authored-by: GenericP3rson <[email protected]>
Co-authored-by: GenericP3rson <[email protected]>
Co-authored-by: GenericP3rson <[email protected]>
Co-authored-by: GenericP3rson <[email protected]>
Co-authored-by: GenericP3rson <[email protected]>
|
@GenericP3rson what do you think about formatting now? |
01110011011101010110010001101111
approved these changes
Jun 11, 2024
01110011011101010110010001101111
changed the base branch from
main
to
unitary-hack
Hanrui-Wang
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Added Quantum Circuit Born Machine (QCBM) algorithm.
Details
torchquantum/algorithms.Mentions
@GenericP3rson