Default enabled "useNewAnglesOrder"

mistic100 · Oct 17, 2024 · b5acfeb · b5acfeb
1 parent 5453380
commit b5acfeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/core/src/Viewer.ts b/packages/core/src/Viewer.ts
@@ -71,9 +71,9 @@ import {
 export class Viewer extends TypedEventTarget<ViewerEvents> {
     /**
      * Change the order in which the panoData and sphereCorrection angles are applied from 'ZXY' to 'YXZ'
-     * Will default to `true` in version 5.11
+     * @deprecated Will be removed in version 5.12
      */
-    static useNewAnglesOrder = false;
+    static useNewAnglesOrder = true;
 
     readonly state: ViewerState;
     readonly config: ParsedViewerConfig;

diff --git a/packages/core/src/services/Renderer.ts b/packages/core/src/services/Renderer.ts
@@ -290,8 +290,8 @@ export class Renderer extends AbstractService {
 
         const i = (cleanCorrection.pan ? 1 : 0) + (cleanCorrection.tilt ? 1 : 0) + (cleanCorrection.roll ? 1 : 0);
         if (!Viewer.useNewAnglesOrder && i > 1) {
-            logWarn(`'panoData' Euler angles will change in version 5.11.0.`);
-            logWarn(`Set 'Viewer.useNewAnglesOrder = true;' to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
+            logWarn(`'panoData' Euler angles have changed in version 5.11.0.`);
+            logWarn(`Remove your 'useNewAnglesOrder' override to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
         }
 
         if (Viewer.useNewAnglesOrder) {
@@ -310,8 +310,8 @@ export class Renderer extends AbstractService {
 
         const i = (cleanCorrection.pan ? 1 : 0) + (cleanCorrection.tilt ? 1 : 0) + (cleanCorrection.roll ? 1 : 0);
         if (!Viewer.useNewAnglesOrder && i > 1) {
-            logWarn(`'sphereCorrection' Euler angles will change in version 5.11.0.`);
-            logWarn(`Set 'Viewer.useNewAnglesOrder = true;' to remove this warning (you might have to adapt your pan/tilt/roll parameters).`);
+            logWarn(`'sphereCorrection' Euler angles have changed in version 5.11.0.`);
+            logWarn(`Remove your 'useNewAnglesOrder' override to remove this warning (you might have to adapt your poseHeading/posePitch/poseRoll parameters).`);
         }
 
         if (Viewer.useNewAnglesOrder) {