Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): update ApPersonService to handle user without endpoint #14080

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

PichuChen
Copy link

What

Fix #13735

Why

endpoint または sharedInbox がnullの場合、更新をスキップします

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Jun 23, 2024
Copy link
Contributor

github-actions bot commented Jun 23, 2024

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (a6edd50) to head (95b5c47).

Files Patch % Lines
...end/src/core/activitypub/models/ApPersonService.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #14080      +/-   ##
===========================================
+ Coverage    61.94%   65.27%   +3.33%     
===========================================
  Files         1004     1004              
  Lines       115259   115261       +2     
  Branches      4594     4570      -24     
===========================================
+ Hits         71399    75241    +3842     
+ Misses       43828    39993    -3835     
+ Partials        32       27       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PichuChen PichuChen changed the title chore(backend): update ApPersonService to handle user without endpoint fix(backend): update ApPersonService to handle user without endpoint Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sharedInboxが無いActorに紐づくリモートユーザーを照会できない
1 participant