Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: U+FE0Fなどがそのまま絵文字としてパースされてしまう #137

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

ikasoba
Copy link

@ikasoba ikasoba commented Dec 26, 2023

What

  • [\uFE00-\uFE0F]が単独で絵文字としてパースされた場合に文字として返すようにしました。

Why

resolve #136 への対応

Additional info (optional)

Copy link

@KisaragiEffective KisaragiEffective left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM 👍

@samunohito
Copy link
Member

samunohito commented Feb 25, 2025

@ikasoba
pr頂いた内容と最新のdevelopの内容が不整合を起こしてビルドが通らなくなっているようです。
可能であればUpdate branchとメンテナンスをお願いできればと思うのですが、如何でしょうか…?

Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ほかは良さそうです

Copy link
Member

@anatawa12 anatawa12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ありがとうございます

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

バグ?:U+FE0Fなどがそのまま絵文字としてパースされてしまう
5 participants