Sub directory handling for deployment #707
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This looks way over complicated. Vite should be able to handle this by itself when you configure |
|
just changing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when deploying the app it assumes to always be at the root directory. This makes it e.g. impossible to deploy via github pages when its not a standard pages repo (the one with
<user>.github.io) as the page will be deployed at<user>.github.io/<project>.This makes it so the deployment directory is configurable via an environment variable
sub_directorythat allows changing it. The github action is also adjusted so if its not in a<user>.github.iorepo it will update the env var.If course this PR won't really benefit the main repo but since i needed this i thought i can share this in case someone else needs it.