Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dimension padding and other things #40

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

jacobsjo
Copy link
Contributor

The main reason for this PR is the change to dimension padding made my mojang in 24w44a by fixing MC-272062. In the process, I also changed a few other things:

  • Dimension padding now affects the start piece. This leads to different structure placement, requiring porting to deepslate (before it only affected the other jigsaw pieces, which isn't part of deepslate)
    • This is a breaking api change because of the addition of levelHeight to the GenerationContext. This is necessary since this depends on the world height set in the dimension_type, and not the noise_settings.
  • StructureSet.getStructureInChunk now returns an object of structure id and starting position. This allows me to display the structure y position on my map. This is also a breaking change
  • Fixes:
    • getBaseHeight had the heightmaps flipped
    • the oldBlendedNoise density function used the wrong seeding
    • fixed endIsland density function

@misode misode merged commit c38265e into misode:main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants