Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --file fish completion #3036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

9999years
Copy link

I assume the fish completions were created by copy/pasting --help output, and --file was mistakenly left in instead of being translated to -l file (that is, --file was passed to complete instead of indicating that there is an option named --file.) This leads to an error when using the completions:

complete: --file: unknown option

/run/current-system/sw/share/fish/vendor_completions.d/hub.fish (line 52): complete -f -c hub -n ' __fish_hub_using_command pull-request' -s F --file -d "Read the pull request title and description from <FILE>" ^
from sourcing file /run/current-system/sw/share/fish/vendor_completions.d/hub.fish

(Type 'help complete' for related documentation)

This patch fixes this error.

I assume the fish completions were created by copy/pasting `--help` output, and `--file` was mistakenly left in instead of being translated to `-l file` (that is, `--file` was passed to `complete` instead of indicating that there is an option _named_ `--file`.) This leads to an error when using the completions:

complete: --file: unknown option

/run/current-system/sw/share/fish/vendor_completions.d/hub.fish (line 52):
complete -f -c hub -n ' __fish_hub_using_command pull-request' -s F --file -d "Read the pull request title and description from <FILE>"
^
from sourcing file /run/current-system/sw/share/fish/vendor_completions.d/hub.fish

(Type 'help complete' for related documentation)

This patch fixes this error.
@andys8
Copy link

andys8 commented Feb 19, 2023

Fixes #2992

@ollema
Copy link

ollema commented Feb 28, 2023

thanks!

I wonder if this will be released anytime soon - considering that the latest release was in 2020

@9999years
Copy link
Author

Yes, this will likely not be merged/released (see #2470), but having the PR here means packagers can cherry-pick the patch for distribution, as I've done here for nixpkgs: NixOS/nixpkgs#217636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants