-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix initialiser location #2574
Open
mansona
wants to merge
1
commit into
miragejs:master
Choose a base branch
from
mansona:relocate-initializer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix initialiser location #2574
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
61 changes: 61 additions & 0 deletions
61
packages/ember-cli-mirage/addon/initializers/ember-cli-mirage.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
import getRfc232TestContext from 'ember-cli-mirage/get-rfc232-test-context'; | ||
import startMirageImpl from 'ember-cli-mirage/start-mirage'; | ||
import * as config from '../mirage/config'; | ||
const { default: makeServer } = config; | ||
|
||
// | ||
// This initializer does two things: | ||
// | ||
// 1. Pulls the mirage config objects from the application's config and | ||
// registers them in the container so `ember-cli-mirage/start-mirage` can | ||
// find them (since it doesn't have access to the app's namespace). | ||
// 2. Provides legacy support for auto-starting mirage in pre-rfc268 acceptance | ||
// tests. | ||
// | ||
export function initialize(application) { | ||
if (makeServer) { | ||
application.register('mirage:make-server', makeServer, { | ||
instantiate: false, | ||
}); | ||
} | ||
|
||
const ENV = application.resolveRegistration('config:environment'); | ||
|
||
ENV['ember-cli-mirage'] = ENV['ember-cli-mirage'] || {}; | ||
if (_shouldUseMirage(ENV.environment, ENV['ember-cli-mirage'])) { | ||
startMirage(application.__container__, ENV); | ||
} | ||
} | ||
|
||
export default { | ||
name: 'ember-cli-mirage', | ||
initialize, | ||
}; | ||
|
||
function startMirage(owner, env) { | ||
return startMirageImpl(owner, { env, makeServer }); | ||
} | ||
|
||
function _shouldUseMirage(env, addonConfig) { | ||
if (typeof FastBoot !== 'undefined') { | ||
return false; | ||
} | ||
if (getRfc232TestContext()) { | ||
return false; | ||
} | ||
let userDeclaredEnabled = typeof addonConfig.enabled !== 'undefined'; | ||
let defaultEnabled = _defaultEnabled(env, addonConfig); | ||
|
||
return userDeclaredEnabled ? addonConfig.enabled : defaultEnabled; | ||
} | ||
|
||
/* | ||
Returns a boolean specifying the default behavior for whether | ||
to initialize Mirage. | ||
*/ | ||
function _defaultEnabled(env, addonConfig) { | ||
let usingInDev = env === 'development' && !addonConfig.usingProxy; | ||
let usingInTest = env === 'test'; | ||
|
||
return usingInDev || usingInTest; | ||
} |
62 changes: 4 additions & 58 deletions
62
packages/ember-cli-mirage/app/initializers/ember-cli-mirage.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,4 @@ | ||
import ENV from '../config/environment'; | ||
import getRfc232TestContext from 'ember-cli-mirage/get-rfc232-test-context'; | ||
import startMirageImpl from 'ember-cli-mirage/start-mirage'; | ||
import * as config from '../mirage/config'; | ||
const { default: makeServer } = config; | ||
|
||
// | ||
// This initializer does two things: | ||
// | ||
// 1. Pulls the mirage config objects from the application's config and | ||
// registers them in the container so `ember-cli-mirage/start-mirage` can | ||
// find them (since it doesn't have access to the app's namespace). | ||
// 2. Provides legacy support for auto-starting mirage in pre-rfc268 acceptance | ||
// tests. | ||
// | ||
export default { | ||
name: 'ember-cli-mirage', | ||
initialize(application) { | ||
if (makeServer) { | ||
application.register('mirage:make-server', makeServer, { | ||
instantiate: false, | ||
}); | ||
} | ||
|
||
ENV['ember-cli-mirage'] = ENV['ember-cli-mirage'] || {}; | ||
if (_shouldUseMirage(ENV.environment, ENV['ember-cli-mirage'])) { | ||
startMirage(application.__container__, ENV); | ||
} | ||
}, | ||
}; | ||
|
||
function startMirage(owner, env = ENV) { | ||
return startMirageImpl(owner, { env, makeServer }); | ||
} | ||
|
||
function _shouldUseMirage(env, addonConfig) { | ||
if (typeof FastBoot !== 'undefined') { | ||
return false; | ||
} | ||
if (getRfc232TestContext()) { | ||
return false; | ||
} | ||
let userDeclaredEnabled = typeof addonConfig.enabled !== 'undefined'; | ||
let defaultEnabled = _defaultEnabled(env, addonConfig); | ||
|
||
return userDeclaredEnabled ? addonConfig.enabled : defaultEnabled; | ||
} | ||
|
||
/* | ||
Returns a boolean specifying the default behavior for whether | ||
to initialize Mirage. | ||
*/ | ||
function _defaultEnabled(env, addonConfig) { | ||
let usingInDev = env === 'development' && !addonConfig.usingProxy; | ||
let usingInTest = env === 'test'; | ||
|
||
return usingInDev || usingInTest; | ||
} | ||
export { | ||
default, | ||
initialize, | ||
} from 'ember-cli-mirage/initializers/ember-cli-mirage'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mansona could you please explain a bit this change?
I got the point about initializer location in app folder and that totally makes sense. But this change seems separate?