Added embroider-safe and embroider-optimized to the test scenarios #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cah-briangantzler in the next release of Embroider we will handle the webpack dependency within the helpers so that dep does not need to be explicitly set. So it might be worth waiting for that |
|
Good to know. Since the change was just made to require the app to do the webpack, I should have just added webpack as a devDependancy instead of what I did and figured that was the desired direction. |
29 tasks
|
Oh nice to see this is already raised @cah-briangantzler. If ya upgrade your dependency of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.