Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify attribution of the Immediate64 implementation #16

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

craigfe
Copy link
Member

@craigfe craigfe commented Mar 29, 2021

CC @avsm.

@dinosaure
Copy link
Member

Thanks

@dinosaure dinosaure merged commit 066a47a into mirage:master Mar 29, 2021
@hannesm
Copy link
Member

hannesm commented Mar 29, 2021

I'm slightly confused: how can this package being advertised as being "MIT licensed" when parts of the source are "licensed along with the OCaml compiler system under LGPLv2"? I'm not a lawyer, but I'd appreciate one of the following:
(a) keep the license as MIT (and do not import "along with the OCaml compiler system under LGPLv2" code into this repository),
(b) keep the LICENSE.md file (and the opam file) reflect the code in this repository,
(c) ask the original author of the (LGPL) code in question whether a relicense to MIT in this package would be possible.

I understand other repositories in the mirage organisation (such as mirage/mirage-solo5#66) have similar inconsistencies, but we should really clean that up.

@craigfe
Copy link
Member Author

craigfe commented Mar 29, 2021

@jeremiedimino: with apologies for not having asked you this in advance, are you happy for these 20 lines of code to be re-licensed under MIT in this repository?

If so, I'll adjust the comment accordingly; if not, I can revert this commit.

@ghost
Copy link

ghost commented Mar 30, 2021

Sure no problem :)

FTR, this code is also part of Base, which is already under MIT: https://github.com/janestreet/base/blob/221b085f3fcd77597f8245b4d73de3970b238e71/src/int63.ml#L9

@hannesm
Copy link
Member

hannesm commented Mar 30, 2021

Thanks @craigfe @jeremiedimino :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants