-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for the less common platforms #261
Conversation
getrandom is not present until Android 28. Confer: https://android.googlesource.com/platform/bionic/+/02ce401d1e2b31586c94c8b6999364bbbce27388/libc/include/sys/random.h
Use memcpy_s for MSVC which is a safe form of memcpy. Documented at https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/memcpy-s-wmemcpy-s?view=msvc-170
Looks fine, thanks. Would you mind to look into the dkml failures? |
Oh, and how widely is android 27 distributed? Does it make sense to support it, or will it be end of life soon? |
Do you need the DkML CI anymore? I'd love to remove it from Mirage since it was a stopgap until opam 2.2 was released. (I believe setup-ocaml can do OCaml 5.3 + Windows/MinGW GCC and hopefully OCaml 5.3 + MSVC. If it isn't obvious/simple how to do that then there is a usability/discoverability issue that should be filed with setup-ocaml and I'd like to know about that). |
Android devices with API 27 will be in distribution (more importantly, supported by the Android NDK) for about 4+ years given the historical trends. It won't be end of life soon. |
Thanks for your headsup. I was not following any dkml/opam 2.2/what to do with the CI here. I'm happy to remove the dkml CI here and replace it with "setup-ocaml/ocaml 5.3 + mingw gcc/msvc". I just don't have any clue which magic runes are necessary. If you feel like, please go ahead and do it (preferably in a separate PR). |
Thanks. I'll submit a separate PR to remove DkML CI. I'll also file an issue with setup-ocaml to send an announcement (or re-announcement?) to discuss.ocaml.org to tell package maintainers like you how they can test Windows. There definitely should not be any magic runes (honestly, it should be automatic)! |
Thanks a lot! |
Fixes the following:
getrandom
but there is a recommended alternative. https://android.googlesource.com/platform/bionic/+/02ce401d1e2b31586c94c8b6999364bbbce27388/libc/include/sys/random.hfill_bytes
.