Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mingw friendly case for includes. #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mingw friendly case for includes. #248

wants to merge 1 commit into from

Conversation

mefyl
Copy link

@mefyl mefyl commented Oct 10, 2024

Since windows filesystem is case insensitive and, AFAIK, windows.h is always lowercase in MinGW distributions, using a lowercase include will work on both transparently.

Currently:

mc_getrandom_stubs.c:60:10: fatal error: Windows.h: No such file or directory
   60 | #include <Windows.h>
      |          ^~~~~~~~~~~

@hannesm
Copy link
Member

hannesm commented Oct 11, 2024

Thanks for your PR. By chance, would you be able to add a GitHub action (or another CI) that tests the "mingw" case?

@mefyl
Copy link
Author

mefyl commented Oct 14, 2024

I'm not really familiar with Github actions; is there already a CI environment cross compiling with mingw ?

@hannesm
Copy link
Member

hannesm commented Oct 14, 2024

I'm not really familiar with Github actions; is there already a CI environment cross compiling with mingw ?

I don't know. Maybe ask the people who're into "windows" and "OCaml" - they must have some secret runes how to test their projects in CI / GitHub actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants