Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reward LP view + Add liquidity button #237

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Reward LP view + Add liquidity button #237

wants to merge 2 commits into from
+1,087 −501

Conversation

amaljosea
Copy link
Contributor

Closes #128

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mira-amm-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 10:46am

@amaljosea amaljosea marked this pull request as ready for review February 5, 2025 05:22
@amaljosea amaljosea requested a review from FossilFrank February 5, 2025 05:23
FossilFrank
FossilFrank requested changes Feb 5, 2025
View reviewed changes
src/hooks/usePositionDetails.ts Outdated
queryKey: ["positionDetails", assetIds],
queryFn: async () => {
const query = gql`
query MyQuery {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a really strange query. Couldn't it be simply something like this?

query {
  asset0: assetsById(id: ${assetIds[0]}) {
    price
  }
  asset1: assetsById(id: ${assetIds[1]}) {
    price
  }
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this and some other improvements in this PR, moving this to draft now.

@amaljosea amaljosea marked this pull request as draft February 5, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FossilFrank FossilFrank FossilFrank requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved reward LP view + Add liquidity button
2 participants
@amaljosea @FossilFrank