-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/mip custom novel #1273
Feat/mip custom novel #1273
Conversation
部署成功,请访问地址获取编译代码。 Built with commit b839ad8 |
src/mip-custom/mip-custom.js
Outdated
var novelInstance = isRootPage ? currentWindow.MIP.novelInstance : currentWindow.parent.MIP.novelInstance | ||
var adsCache = novelInstance.adsCache || {} | ||
var me = this; | ||
var novelAds = adsCache.adStategyCacheData.template; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些数据都不用做存在性的判断么
var adsCache = novelInstance.adsCache || {} | ||
var me = this; | ||
var novelAds = adsCache.adStategyCacheData.template; | ||
if (novelAds) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Array.isArray 来判断数组吧
src/mip-custom/mip-custom.js
Outdated
var novelAds = adsCache.adStategyCacheData.template; | ||
if (novelAds) { | ||
novelAds.map(function (value) { | ||
value.map(function (ad) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里要判断数据是否是数组么
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
提交pr时需要关联issue,请大家遵守
#1272
1、升级点 (清晰准确的描述升级的功能点)
配合小说的广告计算展现不同广告
2、影响范围 (描述该需求上线会影响什么功能)
已经做小流量命中小流量,有影响
3、自测 checklist
chrome
4、需要覆盖的场景和case
5、自测机型和浏览器
温馨提示:非 mip-extensions 仓库的组件请在组件平台提交,否则一律打回;