Skip to content

Commit

Permalink
Merge pull request #463 from minvws/copy_export_217
Browse files Browse the repository at this point in the history
Copy export for 217
  • Loading branch information
BartNijland91 authored Jul 13, 2021
2 parents 50b9cc1 + 5ad6083 commit c4926b0
Show file tree
Hide file tree
Showing 8 changed files with 7 additions and 161 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ import nl.rijksoverheid.ctr.shared.utils.Accessibility.setAccessibilityFocus
class HolderMainFragment : BaseMainFragment(
R.layout.fragment_main, setOf(
R.id.nav_my_overview,
R.id.nav_about_this_app,
R.id.nav_qr_explanation_root
R.id.nav_about_this_app
)
) {

Expand Down Expand Up @@ -160,7 +159,7 @@ class HolderMainFragment : BaseMainFragment(
.styleTitle(context, R.attr.textAppearanceHeadline6)
binding.navView.menu.findItem(R.id.nav_settings)
.styleTitle(context, R.attr.textAppearanceHeadline6)
binding.navView.menu.findItem(R.id.nav_qr_explanation_root)
binding.navView.menu.findItem(R.id.action_qr_type)
.styleTitle(context, R.attr.textAppearanceHeadline6)
binding.navView.menu.findItem(R.id.nav_about_this_app)
.styleTitle(context, R.attr.textAppearanceBody1)
Expand All @@ -169,5 +168,4 @@ class HolderMainFragment : BaseMainFragment(
binding.navView.menu.findItem(R.id.nav_terms_of_use)
.styleTitle(context, R.attr.textAppearanceBody1)
}

}

This file was deleted.

66 changes: 0 additions & 66 deletions holder/src/main/res/layout/fragment_qr_explanation.xml

This file was deleted.

2 changes: 1 addition & 1 deletion holder/src/main/res/menu/navigation_drawer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
android:title="@string/my_overview" />

<item
android:id="@+id/nav_qr_explanation_root"
android:id="@+id/action_qr_type"
android:checkable="false"
android:title="@string/choose_provider_toolbar" />

Expand Down
2 changes: 1 addition & 1 deletion holder/src/main/res/menu/overview_toolbar.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<menu xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto">
<item
android:id="@+id/nav_qr_explanation"
android:id="@+id/action_qr_type"
android:icon="@drawable/ic_add"
android:title=""
app:contentDescription="@string/my_overview_no_qr_make_qr_button"
Expand Down
54 changes: 0 additions & 54 deletions holder/src/main/res/navigation/holder_nav_graph_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@
app:popEnterAnim="@anim/fragment_close_enter"
app:popExitAnim="@anim/fragment_close_exit" />

<action
android:id="@+id/action_make_appointment"
app:destination="@id/nav_make_appointment"
app:enterAnim="@anim/fragment_open_enter"
app:exitAnim="@anim/fragment_open_exit"
app:popEnterAnim="@anim/fragment_close_enter"
app:popExitAnim="@anim/fragment_close_exit" />

<action
android:id="@+id/action_qr_code"
app:destination="@id/nav_qr_code"
Expand All @@ -46,14 +38,6 @@
app:popEnterAnim="@anim/fragment_close_enter"
app:popExitAnim="@anim/fragment_close_exit" />

<action
android:id="@+id/action_create_qr"
app:destination="@id/nav_qr_explanation"
app:enterAnim="@anim/fragment_open_enter"
app:exitAnim="@anim/fragment_open_exit"
app:popEnterAnim="@anim/fragment_close_enter"
app:popExitAnim="@anim/fragment_close_exit" />

<action
android:id="@+id/action_qr_type"
app:destination="@id/nav_qr_code_type"
Expand Down Expand Up @@ -120,38 +104,6 @@

</dialog>

<fragment
android:id="@+id/nav_qr_explanation_root"
android:name="nl.rijksoverheid.ctr.holder.ui.create_qr.QrExplanationFragment"
android:label="@string/choose_provider_toolbar"
tools:layout="@layout/fragment_qr_explanation">

<action
android:id="@+id/action_qr_type"
app:destination="@id/nav_qr_code_type"
app:enterAnim="@anim/slide_in_right"
app:exitAnim="@anim/slide_out_left"
app:popEnterAnim="@anim/slide_in_left"
app:popExitAnim="@anim/slide_out_right" />

</fragment>

<fragment
android:id="@+id/nav_qr_explanation"
android:name="nl.rijksoverheid.ctr.holder.ui.create_qr.QrExplanationFragment"
android:label="@string/choose_provider_toolbar"
tools:layout="@layout/fragment_qr_explanation">

<action
android:id="@+id/action_qr_type"
app:destination="@id/nav_qr_code_type"
app:enterAnim="@anim/slide_in_right"
app:exitAnim="@anim/slide_out_left"
app:popEnterAnim="@anim/slide_in_left"
app:popExitAnim="@anim/slide_out_right" />

</fragment>

<fragment
android:id="@+id/nav_qr_code_type"
android:name="nl.rijksoverheid.ctr.holder.ui.create_qr.QrCodeTypeFragment"
Expand Down Expand Up @@ -464,12 +416,6 @@

</fragment>

<fragment
android:id="@+id/nav_make_appointment"
android:name="nl.rijksoverheid.ctr.holder.ui.make_appointment.MakeAppointmentFragment"
android:label="@string/test_appointment_info_toolbar_title"
tools:layout="@layout/fragment_make_appointment" />

<fragment
android:id="@+id/nav_about_this_app"
android:name="nl.rijksoverheid.ctr.design.menu.about.AboutThisAppFragment"
Expand Down
6 changes: 2 additions & 4 deletions holder/src/main/res/values-en/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@
<string name="url_accessibility">https://coronacheck.nl/en/accessibility-in-app</string>
<string name="create_qr_explanation_menu_title">Make QR code</string>
<string name="create_qr_explanation_menu_title_alternative">Add a QR code</string>
<string name="create_qr_explanation_title">Make a QR code</string>
<string name="create_qr_explanation_description"><![CDATA[The app makes a QR code in three steps. This QR code is your personal certificate.<br/><br/><b>1. Choose the type of certificate</b><br/>Choose to create a vaccination certificate, a test certificate or a recovery certificate.<br/><br/><b>2. Automatically retrieve data
</b><br/>The app directly retrieves the data of your vaccination, test result or recovery.<br/><br/><b>

3. QR codes are ready
</b><br/>The app generates a QR code for the Netherlands and one for other countries. <br/><br/>]]></string>
<string name="qr_code_type_title">What kind of certificate would you like to add?</string>
<string name="qr_code_type_description">Indicate what kind of certificate you would like to add. You can have multiple certificates.</string>
<string name="qr_code_type_negative_test_title">A test certificate</string>
Expand Down Expand Up @@ -309,10 +307,10 @@
<string name="my_overview_green_card_server_error_after_retry"><![CDATA[or call the help desk at 0800-1421 (free)]]></string>
<string name="my_overview_green_card_internet_error"><![CDATA[Connect to the internet to make sure <br\> your QR code works again. <a href="#">Try again</a>]]></string>
<string name="dialog_faultyvaccination28June_title">Vaccination certificate corrected</string>
<string name="dialog_faultyvaccination28June_message">Due to a technical error you’ve wrongly received a Dutch vaccination certificate. This was corrected.</string>
<string name="dialog_faultyvaccination28June_message">You’ve wrongly received a Dutch vaccination certificate due to a technical error. This was corrected.</string>
<string name="dialog_faultyvaccination28June_refresh_error_title">Something went wrong while refreshing your details</string>
<string name="dialog_faultyvaccination28June_refresh_error_message">Please retrieve your details again via the app.</string>
<string name="my_overview_qr_placeholder_header">Find your certificate here later</string>
<string name="my_overview_qr_placeholder_description"><![CDATA[You can add a certificate if you\'re vaccinated, if you\'ve had corona or by taking a test at an <a href="https://coronacheck.nl/en/testafspraak-in-app">affiliated test location</a>. The app generates a certificate for the Netherlands and one for other countries.<br /></p><p><b>Travelling outside the Netherlands?</b><br />Check <a href="www.nederlandwereldwijd.nl/reizen/reisadviezen">wijsopreis.nl</a> before you leave. There you will find which certificate is valid in the country you’re planning to visit.]]></string>
<string name="my_overview_qr_placeholder_description"><![CDATA[You can add a certificate if you\'re vaccinated, if you\'ve had corona or by taking a test at an <a href="https://coronacheck.nl/en/testafspraak-in-app">affiliated test location</a>. The app generates a certificate for the Netherlands and one for other countries.<br /></p><p><b>Travelling outside the Netherlands?</b><br />Check <a href="https://www.nederlandwereldwijd.nl/reizen/reisadviezen">wijsopreis.nl</a> before you leave. There you will find which certificate is valid in the country you’re planning to visit.]]></string>
<string name="my_overview_add_qr_button">Add certificate</string>
</resources>
4 changes: 1 addition & 3 deletions holder/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,6 @@
<string name="url_accessibility">https://coronacheck.nl/nl/accessibility-in-app</string>
<string name="create_qr_explanation_menu_title">QR-code maken</string>
<string name="create_qr_explanation_menu_title_alternative">Voeg een QR-code toe</string>
<string name="create_qr_explanation_title">Een QR-code maken</string>
<string name="create_qr_explanation_description"><![CDATA[De app maakt in 3 stappen een QR-code. De QR-code is jouw bewijs.<br/><br/><b>1. Kies het soort bewijs</b><br/>Je kan een vaccinatiebewijs, een testbewijs of een herstelbewijs maken.<br/><br/><b>2. Automatisch gegevens ophalen</b><br/>De app haalt direct de gegevens van je vaccinatie, testuitslag of herstel op.<br/><br/><b>3. QR-codes staan klaar</b><br/>De app maakt twee QR-codes: een QR-code voor Nederland en een internationale.]]></string>
<string name="qr_code_type_title">Welk bewijs wil je toevoegen?</string>
<string name="qr_code_type_description">Geef aan wat voor bewijs je wil toevoegen. Je kunt meerdere bewijzen tegelijk hebben.</string>
<string name="qr_code_type_negative_test_title">Een testbewijs</string>
Expand Down Expand Up @@ -313,6 +311,6 @@
<string name="dialog_faultyvaccination28June_refresh_error_title">Er is iets misgegaan bij het vernieuwen van je gegevens</string>
<string name="dialog_faultyvaccination28June_refresh_error_message">Haal je gegevens opnieuw op via de app.</string>
<string name="my_overview_qr_placeholder_header">Hier komt jouw bewijs</string>
<string name="my_overview_qr_placeholder_description"><![CDATA[Je kunt een bewijs toevoegen als je bent gevaccineerd of hersteld. Of als je bent getest bij een <a href="https://coronacheck.nl/nl/testafspraak-in-app">aangesloten testlocatie</a>. De app maakt een Nederlands en een internationaal bewijs.<br /></p><p><b>Reis je buiten Nederland?</b><br />Check <a href="www.nederlandwereldwijd.nl/reizen/reisadviezen">wijsopreis.nl</a> voor vertrek. Daar staat welk bewijs geldig is in het land dat je bezoekt.]]></string>
<string name="my_overview_qr_placeholder_description"><![CDATA[Je kunt een bewijs toevoegen als je bent gevaccineerd of hersteld. Of als je bent getest bij een <a href="https://coronacheck.nl/nl/testafspraak-in-app">aangesloten testlocatie</a>. De app maakt een Nederlands en een internationaal bewijs.<br /></p><p><b>Reis je buiten Nederland?</b><br />Check <a href="https://www.nederlandwereldwijd.nl/reizen/reisadviezen">wijsopreis.nl</a> voor vertrek. Daar staat welk bewijs geldig is in het land dat je bezoekt.]]></string>
<string name="my_overview_add_qr_button">Bewijs toevoegen</string>
</resources>

0 comments on commit c4926b0

Please sign in to comment.