fix misleading test

minvws · May 17, 2022 · 32ed73d · 32ed73d
1 parent 454166d
commit 32ed73d
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 5 deletions.
diff --git a/design/src/main/java/nl/rijksoverheid/ctr/design/ext/SpannedExt.kt b/design/src/main/java/nl/rijksoverheid/ctr/design/ext/SpannedExt.kt
@@ -3,7 +3,6 @@ package nl.rijksoverheid.ctr.design.ext
 import android.text.Spanned
 import android.text.style.BulletSpan
 import android.text.style.RelativeSizeSpan
-import android.text.style.StyleSpan
 import androidx.core.text.getSpans
 import nl.rijksoverheid.ctr.design.spans.BulletPointSpan
 

diff --git a/holder/src/test/java/nl/rijksoverheid/ctr/HtmlTextViewWidgetTest.kt b/holder/src/test/java/nl/rijksoverheid/ctr/HtmlTextViewWidgetTest.kt
@@ -13,6 +13,7 @@ import androidx.core.view.ViewCompat
 import androidx.core.view.children
 import androidx.test.core.app.ApplicationProvider
 import nl.rijksoverheid.ctr.design.widgets.HtmlTextViewWidget
+import org.junit.Assert.assertTrue
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.koin.test.AutoCloseKoinTest
@@ -50,12 +51,30 @@ class HtmlTextViewWidgetTest : AutoCloseKoinTest() {
 
         // Heading test
         widget.setHtmlText("<strong>Heading 1</strong><p>Paragraph 1</p><strong>Heading 2</strong><p>Paragraph 2</p>")
-        assertEquals(widget.children.filter { ViewCompat.isAccessibilityHeading(it) }.count(), 0) // 2: Heading 1 + Heading 2
+        assertEquals(
+            widget.children.filter { ViewCompat.isAccessibilityHeading(it) }.count(),
+            0
+        ) // 2: Heading 1 + Heading 2
         assertEquals(widget.childCount, 1) // 5: Heading + Text + Linebreak + Heading + Text
 
-        widget.setHtmlText("<h1>Heading 1</h1><h2>Heading 2</h2><h3>Heading 3</h3><h4>Heading 4</h4><h5>Heading 5</h5><h6>Heading 6</h6>")
-        assertEquals(widget.children.filter { ViewCompat.isAccessibilityHeading(it) }.count(), 0) // 6: h1, h2, h3, h4, h5, h6
-        assertEquals(widget.childCount, 1) // 7: Heading + Heading + Heading + Heading + Heading + Heading + Linebreak
+        widget.setHtmlText("<h1>Heading 1</h1>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
+        widget.setHtmlText("<h2>Heading 1</h2>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
+        widget.setHtmlText("<h3>Heading 1</h3>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
+        widget.setHtmlText("<h4>Heading 1</h4>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
+        widget.setHtmlText("<h5>Heading 1</h5>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
+        widget.setHtmlText("<h6>Heading 1</h6>")
+        assertEquals(1, widget.childCount)
+        assertTrue(ViewCompat.isAccessibilityHeading(widget.getChildAt(0)))
 
         // List test
         widget.setHtmlText("<ul><li>List item 1</li><li>List item 2</li></ul>")