Merge pull request #751 from minvws/2165-fix-voiceover

let talkback announce the previous/next qr code buttons
minvws · Oct 13, 2021 · 2323887 · 2323887
2 parents c1ec648 + 2f0583d
commit 2323887
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/holder/src/main/res/layout/fragment_qr_codes.xml b/holder/src/main/res/layout/fragment_qr_codes.xml
@@ -44,7 +44,8 @@
                 app:layout_constraintHorizontal_chainStyle="spread_inside"
                 app:layout_constraintStart_toStartOf="parent"
                 app:layout_constraintTop_toTopOf="@+id/qrVaccinationDosis"
-                tools:visibility="visible" />
+                tools:visibility="visible"
+                android:contentDescription="@string/qr_code_previous_button" />
 
             <TextView
                 android:id="@+id/qrVaccinationDosis"
@@ -72,7 +73,8 @@
                 app:layout_constraintEnd_toEndOf="parent"
                 app:layout_constraintStart_toEndOf="@+id/qrVaccinationDosis"
                 app:layout_constraintTop_toTopOf="@+id/qrVaccinationDosis"
-                tools:visibility="visible" />
+                tools:visibility="visible"
+                android:contentDescription="@string/qr_code_next_button" />
 
         </androidx.constraintlayout.widget.ConstraintLayout>
 

diff --git a/holder/src/main/res/values-en/strings.xml b/holder/src/main/res/values-en/strings.xml
@@ -471,6 +471,8 @@
     <string name="qr_code_newer_dose_available">You probably won\'t need this QR code because you have a more recent dose.</string>
     <string name="qr_code_hidden_title">QR code hidden</string>
     <string name="qr_code_hidden_button">Show anyway</string>
+    <string name="qr_code_previous_button">Previous QR code</string>
+    <string name="qr_code_next_button">Next QR code</string>
     <string name="my_overview_results_button">View QR codes</string>
     <string name="dashboard_item_refresh_eu_vaccinations_text">You can renew your international vaccination certificate</string>
     <string name="dashboard_item_refresh_eu_vaccinations_button">Read more</string>

diff --git a/holder/src/main/res/values/strings.xml b/holder/src/main/res/values/strings.xml
@@ -471,6 +471,8 @@
     <string name="qr_code_newer_dose_available">Deze QR-code heb je waarschijnlijk niet nodig, want je hebt een nieuwere dosis.</string>
     <string name="qr_code_hidden_title">QR-code verborgen</string>
     <string name="qr_code_hidden_button">Laat toch zien</string>
+    <string name="qr_code_previous_button">Vorige QR-code</string>
+    <string name="qr_code_next_button">Volgende QR-code</string>
     <string name="my_overview_results_button">Bekijk QR-codes</string>
     <string name="dashboard_item_refresh_eu_vaccinations_text">Je kan je internationale vaccinatiebewijs vernieuwen</string>
     <string name="dashboard_item_refresh_eu_vaccinations_button">Lees meer</string>