Feature/mintlayer pk #1

OBorce · 2024-05-15T09:36:11Z

Add new messages in the proto files for Mintlayer coin support, and handlers.

azarovh · 2024-08-06T09:55:45Z

I wouldn't merge this to master but rather created a separate branch like mintlayer-master and merge features there. This way we can keep it clean and isolated and when we decide to update trezor version we will pull to master and rebase our master. Otherwise it could become a mess very quickly. Makes sense?

One thing to consider is that CI might not work for "our" master.

ImplOfAnImpl

As I can see, there are still many FIXMEs and commented lines, so it seems like this is still work-in-progress.

core/embed/extmod/modtrezorcrypto/modtrezorcrypto-bip32.h

core/embed/extmod/modtrezormintlayer/modtrezormintlayer-utils.h

rust/trezor-client/src/error.rs

core/src/apps/bitcoin/sign_tx/layout.py

core/src/apps/workflow_handlers.py

core/src/trezor/crypto/bech32.py

azarovh

looks good to me

ImplOfAnImpl

I guess it makes sense to review it one more time after the comments are applied.

core/src/apps/mintlayer/sign_tx/signer.py

common/protob/messages-mintlayer.proto

rust/trezor-client/src/error.rs

rust/trezor-client/src/client/mintlayer.rs

ImplOfAnImpl · 2024-12-13T09:22:12Z

tests/device_tests/mintlayer/test_get_public_key.py

+@pytest.mark.setup_client(
+    mnemonic="abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about"
+)
+def test_mintlayer_get_public_key(client: Client):


We need tests for get_address as well (both for testbet and mainnet).

Though I'm still not sure how the network type should be passed to the firmware. The original code seems to use CoinInfo for that.

Though I'm still not sure how the network type should be passed to the firmware. The original code seems to use CoinInfo for that.

I think we should use CoinInfo too, so that we can call validate_path_against_script_type in get_address/get_public_key/sign_message, which will ensure that the derivation path is correct and show a warning to the user if it's not (as I can see from the code at least)

common/protob/messages-mintlayer.proto

ImplOfAnImpl · 2024-12-17T11:54:45Z

Regarding CoinInfo - I still don't see how having a CoinInfo of our own can interfere with the existing btc-related code. Am I missing something?
Regarding where to put the definitions for ML and TML - we could put it into misc.json. The only problem is that currently it doesn't allow specifying whether the coin is a testnet one and _load_misc in core/vendor/trezor-common/tools/coin_info.py always sets is_testnet to False. I guess we could make is_testnet optional, defaulting to False.

ImplOfAnImpl

Btw, trezor-client is outdated, e.g. it references MintlayerRequestType::TXMETA which is no longer there.
And the brach refactor/wallet-generic-signer in the main repo seems to be outdated too. I wonder if you just forgot to push the changes.

ImplOfAnImpl · 2025-01-06T12:15:09Z

python/src/trezorlib/cli/mintlayer.py

+    \b
+    $ trezorctl mintlayer get-address -n m/44h/19788h/0h/0/0
+    """


It's better to have an example for --coin, including its possible values.

ImplOfAnImpl · 2025-01-06T12:35:40Z

core/src/apps/mintlayer/__init__.py

+    if name == REGTEST_COIN.coin_name:
+        return REGTEST_COIN
+
+    raise ValueError(f"unknown coin type {name}")


This results in a cryptic message in trezorctl: Error: FirmwareError: Firmware error. We should either catch such exceptions later and rethrow something from wire.errors, such as DataError, or throw DataError in the first place.
(I suggest aways throwing DataError or one of its friends from wire.errors unless we actually need to catch the exception in the firmware).

ImplOfAnImpl · 2025-01-06T12:42:14Z

core/src/apps/mintlayer/sign_message.py

+            coin_info.prefixes.public_key_hash, data, Encoding.BECH32M
+        )
+    else:
+        raise ValueError(f"Unknown Address type {msg.address_type}")


ImplOfAnImpl · 2025-01-06T12:44:13Z

core/src/apps/mintlayer/sign_tx/layout.py

+                raise ValueError("Token Fixed supply without amount")
+            fixed_amount = int.from_bytes(x.total_supply.fixed_amount, "big")
+            formated_amount = format_amount(fixed_amount, x.number_of_decimals)
+            total_supply = f"FIXED {formated_amount}"
+        else:
+            raise ValueError("Unhandled Token total supply type")


ImplOfAnImpl · 2025-01-06T15:20:13Z

common/protob/messages-mintlayer.proto

+message MintlayerSignMessage {
+    repeated uint32 address_n = 1;                     // BIP-32 path to derive the key from master node
+    required string coin_name = 2;                     // Coin to use Testnet or Mainnet
+    required MintlayerAddressType address_type = 3;    // destination address in bech32 encoding


Wrong comment

OBorce force-pushed the feature/mintlayer-pk branch from bddbd25 to 967640b Compare July 16, 2024 09:08

OBorce force-pushed the feature/mintlayer-pk branch from 5abd648 to 798be63 Compare August 6, 2024 09:54

ImplOfAnImpl reviewed Aug 7, 2024

View reviewed changes

OBorce force-pushed the feature/mintlayer-pk branch 16 times, most recently from 941d641 to dd3f1e8 Compare September 12, 2024 16:29

OBorce changed the base branch from master to main September 12, 2024 16:32

OBorce force-pushed the feature/mintlayer-pk branch 9 times, most recently from 08dce8d to 77bb6af Compare September 16, 2024 23:28

azarovh approved these changes Nov 25, 2024

View reviewed changes

OBorce added 3 commits December 2, 2024 20:00

Change mintlayer sing tx response message

a4b05ad

fix CI pipeline warning

836813f

Revert poetry.lock and ignore statement to fix CI

0e27aff

OBorce force-pushed the feature/mintlayer-pk branch from 554dbfd to 0e27aff Compare December 2, 2024 19:01

OBorce added 2 commits December 3, 2024 15:18

handle produce from block UTXO for tx fees

4a55173

fix build warning

c213ea6

OBorce force-pushed the feature/mintlayer-pk branch 3 times, most recently from 2456d64 to 781eb0d Compare December 4, 2024 13:33

Handle passphrase on the device

c929c9a

OBorce force-pushed the feature/mintlayer-pk branch from 781eb0d to c929c9a Compare December 4, 2024 15:26

OBorce force-pushed the feature/mintlayer-pk branch 2 times, most recently from c75c2a2 to 9fb3fc1 Compare December 13, 2024 09:17

ImplOfAnImpl reviewed Dec 13, 2024

View reviewed changes

Use enums from protos

6e03e86

OBorce force-pushed the feature/mintlayer-pk branch from 9fb3fc1 to 6e03e86 Compare December 13, 2024 10:39

OBorce added 2 commits December 19, 2024 09:58

fix comments

e723586

roll back CHANGELOGS

dbde1a6

OBorce force-pushed the feature/mintlayer-pk branch 3 times, most recently from 15c716f to a6eca9f Compare December 19, 2024 09:33

fix styling

40022df

OBorce force-pushed the feature/mintlayer-pk branch from a6eca9f to 40022df Compare December 23, 2024 08:58

ImplOfAnImpl reviewed Jan 6, 2025

View reviewed changes

Handle Mintlayer order inputs and fees

361cb0a

OBorce force-pushed the feature/mintlayer-pk branch from 1768ae8 to 361cb0a Compare January 8, 2025 10:10

add Mintlayer chain type to proto messages

04bd932

OBorce force-pushed the feature/mintlayer-pk branch from 877bde1 to 04bd932 Compare January 12, 2025 12:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/mintlayer pk #1

Feature/mintlayer pk #1

OBorce commented May 15, 2024 •

edited

Loading

azarovh commented Aug 6, 2024 •

edited

Loading

ImplOfAnImpl left a comment

azarovh left a comment

ImplOfAnImpl left a comment

ImplOfAnImpl Dec 13, 2024

ImplOfAnImpl Dec 16, 2024

ImplOfAnImpl commented Dec 17, 2024

ImplOfAnImpl left a comment

ImplOfAnImpl Jan 6, 2025

ImplOfAnImpl Jan 6, 2025

ImplOfAnImpl Jan 6, 2025

ImplOfAnImpl Jan 6, 2025

ImplOfAnImpl Jan 6, 2025

Feature/mintlayer pk #1

Are you sure you want to change the base?

Feature/mintlayer pk #1

Conversation

OBorce commented May 15, 2024 • edited Loading

azarovh commented Aug 6, 2024 • edited Loading

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

azarovh left a comment

Choose a reason for hiding this comment

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

ImplOfAnImpl Dec 13, 2024

Choose a reason for hiding this comment

ImplOfAnImpl Dec 16, 2024

Choose a reason for hiding this comment

ImplOfAnImpl commented Dec 17, 2024

ImplOfAnImpl left a comment

Choose a reason for hiding this comment

ImplOfAnImpl Jan 6, 2025

Choose a reason for hiding this comment

ImplOfAnImpl Jan 6, 2025

Choose a reason for hiding this comment

ImplOfAnImpl Jan 6, 2025

Choose a reason for hiding this comment

ImplOfAnImpl Jan 6, 2025

Choose a reason for hiding this comment

ImplOfAnImpl Jan 6, 2025

Choose a reason for hiding this comment

OBorce commented May 15, 2024 •

edited

Loading

azarovh commented Aug 6, 2024 •

edited

Loading