-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker images and provide examples #1532
Conversation
91dc5c6
to
05c1a5d
Compare
So, I've taken over this PR and pushed some commits. The PR is curently based on the "fix/locked-utxo-conflict" branch, because that branch contains some fixes required for api scanner daemon to work properly.
Regarding the question whether we should have the ability to run wallet-cli via docker compose.
|
build-tools/docker/example-mainnet-dns-server/container_home/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments, this looks fine. I want Enrico to review it though to see if this is what he expects.
05c1a5d
to
40df24d
Compare
I've revamped dockerfiles once more. Now they don't use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the p2p port issue, this is looking OK at this point.
5976920
to
7297581
Compare
…yml files for different services)
…active) services; put dns-server in a separate project; mount container's home dir to host dir instead of a volume.
… docker compose project can now run wallet-cli via "exec".
…non-root user and chown the mounted host dir. Reduce code duplication in dockerfiles. Minor improvements.
improve comments; use localhost as the bind address for rpc calls and api servers' postgres db; unify argument passing via env vars for wallet and wallet rpc daemon; a bit more logging
7297581
to
6e5f448
Compare
This PR adds more images for
api-blockchain-scanner-daemon
,api-web-server
,dns_server
,wallet-rpc-daemon
and removes the image fornode-gui
. In addition runs the commands as normal user (mintlayer
) instead of the defaultroot
user.TODO:
Add/fix documentation(will be done separately)Add an example to run a whole block explorer in a docker-compose file.(it's better to do this in the block explorer's own repository)--rpc-address node-daemon:3030
should work).