Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create TextSummary trait #1530

Merged
merged 2 commits into from
Feb 5, 2024
Merged

Create TextSummary trait #1530

merged 2 commits into from
Feb 5, 2024

Conversation

TheQuantumPhysicist
Copy link
Contributor

No description provided.

Base automatically changed from p2p_peer_discouragement to master February 2, 2024 16:13
iljakuklic
iljakuklic approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@iljakuklic iljakuklic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think it would be better to use std::fmt::Write to avoid all the intermediate strings but that's not that important.

@TheQuantumPhysicist TheQuantumPhysicist merged commit cd4b27d into master Feb 5, 2024
16 checks passed
@TheQuantumPhysicist TheQuantumPhysicist deleted the fix/transaction-summary branch February 5, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iljakuklic iljakuklic iljakuklic approved these changes

@erubboli erubboli Awaiting requested review from erubboli erubboli is a code owner

@azarovh azarovh Awaiting requested review from azarovh azarovh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheQuantumPhysicist @iljakuklic