Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep delegations in the db #1523

Merged
merged 6 commits into from
Feb 5, 2024
Merged

Keep delegations in the db #1523

merged 6 commits into from
Feb 5, 2024

Conversation

azarovh
Copy link
Member

@azarovh azarovh commented Jan 31, 2024

  • Remove the code that cleans up delegations from db if the balance is 0 and the pool is decommissioned. It's error prone and also it only deletes one delegation per transaction while there could be multiple.
  • Introduce additional check for TxInputs from accounts to check provided amount against actual balances.

@azarovh azarovh marked this pull request as draft February 1, 2024 13:48
@azarovh azarovh force-pushed the fix/delegation_inputs_spending branch 2 times, most recently from 228902c to b1a6ddb Compare February 1, 2024 15:21
@azarovh azarovh marked this pull request as ready for review February 1, 2024 15:22
@azarovh azarovh requested a review from OBorce February 2, 2024 09:41
@azarovh azarovh force-pushed the fix/delegation_inputs_spending branch 2 times, most recently from dfaec5e to a9b3951 Compare February 2, 2024 10:11
@azarovh azarovh force-pushed the fix/delegation_inputs_spending branch from a9b3951 to fedfe81 Compare February 2, 2024 10:12
@azarovh azarovh merged commit f630721 into master Feb 5, 2024
27 checks passed
@azarovh azarovh deleted the fix/delegation_inputs_spending branch February 5, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants