Make sure we try destructure the right thing.#720
Merged
gdotdesign merged 1 commit intomasterfrom Dec 3, 2024
Merged
Conversation
Sija
approved these changes
Dec 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if we have a type and a module with the same name and try to match on a value of the type will find the module first, which can lead to errors:
It would
App.Page.Settingswould resolve theApp.Pagemodule instead of the type it errors out since there is noSettingsin the module.This PR fixes that by checking if there is a type and a variant before checking the module and it's entities.