-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight Mint code in Markdown content. #677
Open
gdotdesign
wants to merge
3
commits into
master
Choose a base branch
from
highlight-in-markdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be useful for static docs generator too. 👍 I was not a huge fan of this |
Sija
reviewed
Sep 29, 2023
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
reviewed
Nov 16, 2023
Comment on lines
+73
to
+94
if language == "mint" | ||
parser = Parser.new(node.text, "source.mint") | ||
parser.parse_any | ||
|
||
parts = | ||
SemanticTokenizer.tokenize(parser.ast) | ||
|
||
parts.each do |item| | ||
case item | ||
in String | ||
@io << '`' << item.gsub('`', "\\`") << '`' | ||
in Tuple(SemanticTokenizer::TokenType, String) | ||
tag("span", {"className" => item[0].to_s.underscore}) | ||
@io << '`' << item[1].gsub('`', "\\`") << '`' | ||
tag_end | ||
end | ||
|
||
@io << ',' | ||
end | ||
else | ||
@io << '`' << node.text.gsub('`', "\\`").strip << '`' | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest extracting this into a dedicated method:
def inline_code(io, code)
io << '`' << code.gsub('`', "\\`") << '`'
end
Suggested change
if language == "mint" | |
parser = Parser.new(node.text, "source.mint") | |
parser.parse_any | |
parts = | |
SemanticTokenizer.tokenize(parser.ast) | |
parts.each do |item| | |
case item | |
in String | |
@io << '`' << item.gsub('`', "\\`") << '`' | |
in Tuple(SemanticTokenizer::TokenType, String) | |
tag("span", {"className" => item[0].to_s.underscore}) | |
@io << '`' << item[1].gsub('`', "\\`") << '`' | |
tag_end | |
end | |
@io << ',' | |
end | |
else | |
@io << '`' << node.text.gsub('`', "\\`").strip << '`' | |
end | |
if language == "mint" | |
parser = Parser.new(node.text, "source.mint") | |
parser.parse_any | |
parts = | |
SemanticTokenizer.tokenize(parser.ast) | |
parts.each do |item| | |
case item | |
in String | |
inline_code(@io, item) | |
in Tuple(SemanticTokenizer::TokenType, String) | |
tag("span", {"className" => item[0].to_s.underscore}) | |
inline_code(@io, item[1]) | |
tag_end | |
end | |
@io << ',' | |
end | |
else | |
inline_code(@io, node.text.strip) | |
end |
This PR is now outdated and will be superseded by the compiler refactor in #680 and will close when that's merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements highlighting for Mint language blocks in Markdown content in here documents.