Improve Development Server #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't type check twice - Only check the hot path not everything
gdotdesign
added
bug
Sija
approved these changes
Sep 24, 2023
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the development server (
mint start) in two ways:Previously, it type-checked the whole application twice on every change 😰
Now it just uses the
Workspacefor the type-checking like everything else.It just type-checks the hot path, not all entities. This speeds up type checking in cases like icons (https://github.com/mint-lang/mint-tabler-icons/blob/master/source/Icons.mint ~60K LOC) where only the icons which are used are type-checked.
After merging this, the roundtrip on every change should be twice as fast as before 🎉