Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jump() function #616

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Conversation

nilslindemann
Copy link
Contributor

@nilslindemann nilslindemann commented Jun 15, 2023

This and that PR (and that PR) belong together. I explain things there.

(Compare with the changes in the 'navigation' PR in the 'mint-runtime' repo.)

User can now choose between `navigate()`, which never jumps, and `jump()` which does, if the URL is a defined route.

The parameter lists and descriptions of the related functions `navigate()` and `setUrl()` are also updated. Renamed `triggerHashJump()` to `triggerJump()`, to fit more to the name of `jump()`.
@Sija Sija requested a review from gdotdesign September 3, 2023 23:19
@Sija Sija added enhancement New feature or request stdlib Standard library related labels Sep 3, 2023
@gdotdesign gdotdesign added this to the 0.19.0 milestone Sep 6, 2023
@gdotdesign gdotdesign merged commit 302f413 into mint-lang:master Sep 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stdlib Standard library related
Development

Successfully merging this pull request may close these issues.

3 participants