Semantic Tokenizer #615
Merged
Semantic Tokenizer #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdotdesign
added
language
Sija
reviewed
Jun 13, 2023
jansul
reviewed
Jun 14, 2023
Sija
reviewed
Jun 14, 2023
Sija
reviewed
Jun 14, 2023
Sija
reviewed
Jun 14, 2023
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
Sija
reviewed
Jul 18, 2023
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
jansul
reviewed
Jul 19, 2023
| "[#{content}, _h(React.Fragment, {}, [#{mapped.join(",\n")}])]" | ||
| end | ||
|
|
||
| def escape_for_javascript(value : String) |
There was a problem hiding this comment.
May be worth adding this as a method on the JS renderer? js.string() or similar? (I'm assuming value here is the rendered HTML?)
Although if this the only use might be overkill 😅
There was a problem hiding this comment.
I don't know where would it be better 🤷 It's only used in the compiler but js is only used in the compiler as well 😄
|
Woops too slow 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for semantic tokenizer for the language server and also for other uses.
Features:
highlightcommand - syntax highlight specific files in the terminal or as HTML files@highlightlanguage feature - same as@formatbut also highlights the given code as HTMLFixes:
ast.nodesarray when parsing a parent node fails.Future work:
This can be used to provide syntax highlighted error messages 🎉