LSP: Fix enum destructuring/id linking to other types with the same n…

…ame (#628)
mint-lang · Aug 22, 2023 · 2d371e9 · 2d371e9
1 parent 150ba48
commit 2d371e9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/spec/language_server/definition/location_link/enum_destructuring_option b/spec/language_server/definition/location_link/enum_destructuring_option
@@ -1,3 +1,9 @@
+component Error {
+  fun render {
+    <div/>
+  }
+}
+-------------------------------------------------------------file component.mint
 /* Comment for Status enum. */
 enum Status {
   Error

diff --git a/spec/language_server/definition/location_link/enum_id_option b/spec/language_server/definition/location_link/enum_id_option
@@ -1,3 +1,9 @@
+component Ok {
+  fun render {
+    <div/>
+  }
+}
+-------------------------------------------------------------file component.mint
 enum Status {
   Error
   Ok

diff --git a/src/parsers/enum_destructuring.cr b/src/parsers/enum_destructuring.cr
@@ -6,11 +6,11 @@ module Mint
 
     def enum_destructuring
       start do |start_position|
-        next unless option = type_id
+        next unless option = type_id track: false
 
         if keyword "::"
           name = option
-          option = type_id! EnumDestructuringExpectedOption
+          option = type_id! EnumDestructuringExpectedOption, track: false
         end
 
         parameters = [] of Ast::Node

diff --git a/src/parsers/enum_id.cr b/src/parsers/enum_id.cr
@@ -30,11 +30,11 @@ module Mint
 
     def enum_id
       start do |start_position|
-        next unless option = type_id
+        next unless option = type_id track: false
 
         if keyword "::"
           name = option
-          option = type_id! EnumIdExpectedOption
+          option = type_id! EnumIdExpectedOption, track: false
         end
 
         self << Ast::EnumId.new(