-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: docs(component): adds the progress bar component to documentation site #379
base: main
Are you sure you want to change the base?
Conversation
Two thoughts:
|
We should probably also check how this works with small screens or long lists. The CSS doesn't seem to make specific accommodations and I expect it will need some. |
Identifies that this component does not have accessibility or responsive design built
Accessibility team has reviewed this. Current findings and open questions are captured in this Google Doc. Let me know if you cannot access this and I will check the sharing settings. |
From a technical/code point of view, the main issue at present is the completed state visually shown by the filled green circle and tick icon is not conveyed to a screen reader (as the visual affordances are just CSS and SVG images). There are a number of ways of addressing this but we think the best approach would be to add visually hidden text. The markup would look something along the lines of this:
I understand the "vh" CSS class is something that can be used from the GOV.UK design system. Side note: "Application complete" might be a confusing if that is just a summary screen and not a step that requires user input. If it's just a summary, potentially it shouldn't be shown as a step in the progress bar. That's a question for discussion! |
Description of the change
Adds documentation for the Progress Bar component to the pattern library documentation site.
Before merging this we require the following.
Release notes
Adds documentation for the Progress Bar component to the pattern library documentation site.