Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at split policy #6353

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

jhpyke
Copy link
Contributor

@jhpyke jhpyke commented Dec 16, 2024

Pull Request Objective

This piece of work is being tracked in
this
GitHub Issue.

This attempts to split the roles for CaDeT into a more limited dev role, and a more highly empowered prod one, in order to allow the prod role to be restricted to a specific runner group (and as such, allow us to put rules on that runner group to ensure it can only target named workflows@main when running. This is in addition to implementing environments to the repo itself, as those can be overridden by user changes.

Checklist

Note

Each items should be checked. Skipping below checks could delay your PR review!

  • I have reviewed the style guide
    and ensured that my code complies with it
  • All checks have passed (or override label applied, if I've
    used the override-static-analysis label, I've explained why)
  • I have self-reviewed my code
  • I have reviewed the checks and can attest they're as expected

Additional Comments

Lemme know if you've got any questions.

@jhpyke jhpyke requested a review from a team as a code owner December 16, 2024 11:51
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-github-actions-roles

Checkov 🛂: success

Trivy 🛂: success

Static Analysis Override Label 🏷️: false

Pusher: @jhpyke, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/github-actions-roles, Workflow: Terraform, Marker: aws-analytical-platform-data-production-github-actions-roles_static_analysis

@jhpyke jhpyke added the draft label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

Terraform Component 🧱: aws-analytical-platform-data-production-github-actions-roles

Terraform Initialization ⚙️: success

Terraform Validation 🤖: success

Terraform Plan 🛠️: success

Pusher: @jhpyke, Action: pull_request, Working Directory: terraform/aws/analytical-platform-data-production/github-actions-roles, Workflow: Terraform, Marker: aws-analytical-platform-data-production-github-actions-roles_plan

@jhpyke jhpyke marked this pull request as draft December 16, 2024 11:52
source = "terraform-aws-modules/iam/aws//modules/iam-policy"
version = "5.48.0"

name_prefix = "create-a-derived-table"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add dev to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants