Repository navigation
feat(policy): add aws:TagKeys and aws:RequestTag for table and warehouse tag writes - #282
Conversation
…use tag writes A policy could allow or deny a whole table or warehouse tag action, but not the tag keys or values in the request, so a deployment could not let users tag tables while keeping some keys off limits. TagTable, TagWarehouse and CreateTable now take aws:TagKeys and aws:RequestTag/<key>, and UntagTable and UntagWarehouse take aws:TagKeys, as AWS does.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe policy condition-key registry now includes ChangesS3 Tables tag conditions
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No demonstrated issue blocks merging. The downstream integration should still be checked when its handler implementation is available. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the tags at play Comment |
Description
Adds the condition keys
aws:TagKeysandaws:RequestTag/<key>. TagTable, TagWarehouse and CreateTable accept both.UntagTable and UntagWarehouse accept
aws:TagKeys. Other actions refuse them.Motivation and Context
A policy could allow or deny a whole table or warehouse tag action, but not the keys or values in the request. AWS
evaluates these keys for S3 Tables tagging, so a policy can, for example, deny writes to
orb.governance.*keys.miniohq/aistor#8032 consumes this.
How to test this PR?
go test ./policy/...(TestS3TablesRequestTagConditions,TestConditionVariableAllowedOnTagKeys)Summary by CodeRabbit
aws:RequestTagandaws:TagKeysconditions for applicable table and warehouse tagging actions.