Skip to content

Conversation

@kuhnroyal
Copy link
Contributor

@kuhnroyal kuhnroyal commented Jul 25, 2025

Description

Target the actual existing deployment pod labels.

There is no name label on the operator pods.
Additionally the label value was changed 4 years ago in dd62a26 from minio-operator to operator.

Related Issue

Type of Change

  • Bug fix 🐛
  • New feature 🚀
  • Breaking change 🚨
  • Documentation update 📖
  • Refactor 🔨
  • Other (please describe) ⬇️

Screenshots (if applicable e.g before/after)

Checklist

  • I have tested these changes
  • I have updated relevant documentation (if applicable)
  • I have added necessary unit tests (if applicable)

Test Steps

Additional Notes / Context

Having the current app.kubernetes.io/name: operator label should probably be adjusted as well since this may collide with other pods.
The original label before the above change was app.kubernetes.io/name: minio-operator.

Target the actual deployment labels.
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your detailed analysis.

@pjuarezd pjuarezd merged commit 89022c7 into minio:master Oct 9, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants