feat: support metrics scrape #2344
Open
+477
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiuker
requested review from
pjuarezd,
ramondeklein,
harshavardhana,
cniackz,
allanrogerr and
dvaldivia
|
We should add a way to scrape v3 metrics as well |
|
@jiuker is there a way we can create tests for this? since this is a new feature? like an integration test? Thanks. |
pjuarezd
force-pushed
the
feat-support-metrics-scrope
branch
from
b38e1b6 to
982f5d4
Compare
pjuarezd
previously approved these changes
Dec 9, 2024
allanrogerr
reviewed
Dec 9, 2024
allanrogerr
reviewed
Dec 10, 2024
|
Will take a look |
jiuker
force-pushed
the
feat-support-metrics-scrope
branch
from
2c7c9e0 to
40012a7
Compare
jiuker
force-pushed
the
feat-support-metrics-scrope
branch
from
40012a7 to
732b95c
Compare
|
@jiuker PTAL - pkg:golang/golang.org/x/[email protected] vulnerability |
allanrogerr
requested changes
Mar 10, 2025
| } | ||
|
|
||
| for index, scrape := range t.Spec.PrometheusOperatorScrapeMetricsPath { | ||
| promConfig.ScrapeConfigs = append(promConfig.ScrapeConfigs, ScrapeConfig{ |
There was a problem hiding this comment.
Consider the following tenant yaml section; note that v3 cluster metrics is scraped using /minio/v3/metrics/cluster/ (see https://github.com/minio/minio/blob/master/docs/metrics/v3.md):
prometheusOperator: true
prometheusOperatorScrapeMetricsPath:
- /minio/v2/metrics/bucket
- /minio/v2/metrics/cluster
- /minio/v2/metrics/node
- /minio/v2/metrics/resource
- /minio/v3/metrics/cluster/
v3 metrics scraping is failing with server returned HTTP status 403 Forbidden. Please try and check this.
There was a problem hiding this comment.
Yesh. Should be like /minio/metrics/v3/*, but that can be set with this strings slice field.
ramondeklein
requested changes
Mar 11, 2025
added 2 commits
March 12, 2025 13:16
ramondeklein
requested changes
Mar 13, 2025
apply suggestion
added 3 commits
March 17, 2025 16:58
cniackz
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support metrics scrape
fix #2327
we just support
/minio/v2/metrics/clusterbeforenow we can do more type for this
like
default is
/minio/v2/metrics/cluster