-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor MinioAdminClient using HTTP client #1291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balamurugana
requested changes
Jul 25, 2023
I rewrote it according to your requests. At the moment I commented all the MinioAdmin commands with |
Signed-off-by: Bala.FA <[email protected]>
This reverts commit a67ffbf.
Signed-off-by: Bala.FA <[email protected]>
harshavardhana
requested changes
Sep 26, 2023
balamurugana
changed the title
MinIO Admin user management using HTTP
Refactor MinioAdminClient using HTTP client
Sep 27, 2023
@pbrw Please fix CI failure |
balamurugana
approved these changes
Sep 27, 2023
pbrw
commented
Sep 27, 2023
harshavardhana
approved these changes
Nov 1, 2023
how do you specify credentials now? Previously MinioAdmin took an alias. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to solve these issues #829 #1243
Now it should be straightforward to implement the rest of MinIO Admin API