-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing white spaces from provided values #2922
Merged
bexsoft
merged 2 commits into
minio:master
from
cniackz:remove-trailing-spaces-from-region
Aug 1, 2023
Merged
Removing white spaces from provided values #2922
bexsoft
merged 2 commits into
minio:master
from
cniackz:remove-trailing-spaces-from-region
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cesnietor
reviewed
Jul 5, 2023
reivaj05
reviewed
Jul 5, 2023
reivaj05
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
bexsoft
reviewed
Jul 5, 2023
harshavardhana
previously approved these changes
Jul 20, 2023
cniackz
force-pushed
the
remove-trailing-spaces-from-region
branch
2 times, most recently
from
July 31, 2023 20:25
dbb9f00
to
570600b
Compare
cniackz
force-pushed
the
remove-trailing-spaces-from-region
branch
from
July 31, 2023 20:31
570600b
to
ec2682b
Compare
cniackz
changed the title
removing white spaces from provided values
Removing white spaces from provided values
Jul 31, 2023
harshavardhana
approved these changes
Jul 31, 2023
cesnietor
approved these changes
Jul 31, 2023
reivaj05
approved these changes
Jul 31, 2023
bexsoft
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #2755
Explanation:
All I am doing is to trim the spaces introduced by the user so that we avoid an invalid configuration:
I think this can be generic as in non of our configurations we need leading or trailing spaces to work, so trim seems to be the solution here.