Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-pecl-redis6 to the PHP workload. #1314

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

notroj
Copy link
Contributor

@notroj notroj commented Nov 13, 2024

No description provided.

Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notroj it looks like this will result in the addition of liblzf, php-pecl-igbinary, and php-pecl-msgpack (although the last two are already conditionalized and could be disabled if unwanted) as dependencies. Could you please confirm what the plans are for those?

Also, do you want to alphabetize this (at least within the php-pecl-* group), and take the opportunity to clean up the duplicate php-pear and php-pecl-zip too?

@notroj
Copy link
Contributor Author

notroj commented Nov 13, 2024

We're going to flip the bconds to default-off for RHEL

@notroj
Copy link
Contributor Author

notroj commented Nov 13, 2024

Also, do you want to alphabetize this (at least within the php-pecl-* group), and take the opportunity to clean up the duplicate php-pear and php-pecl-zip too?

Thanks hadn't spotted it - I will be updating #1315 to move these components to a new SST, I'll do it then.

@yselkowitz
Copy link
Collaborator

And liblzf will end up added, or are you going to use the bundled version for RHEL/ELN?

@yselkowitz
Copy link
Collaborator

Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package has been conditionalized for ELN.

@yselkowitz yselkowitz merged commit aaf079e into minimization:main Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants