Way to make drawers public! (tested on area mod) #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Jan 2, 2022
Comment on lines
+161
to
+162
| local idef = core.registered_items[iname] | ||
| if idef.groups.drawer_public == 1 then |
There was a problem hiding this comment.
idef might be nil when items are removed from the game. This is an edge-case, but yet a potential bug.
Also I suggest to move all protection checks to a local function so that on_rightclick and on_punch use the identical checks.
S-S-X
reviewed
Oct 14, 2022
| for _,itemStack in pairs(upgrades) do | ||
| local iname = itemStack:get_name() | ||
| local idef = core.registered_items[iname] | ||
| if idef.groups.drawer_public == 1 then |
There was a problem hiding this comment.
Suggested change
| if idef.groups.drawer_public == 1 then | |
| if idef and idef.groups.drawer_public == 1 then |
S-S-X
reviewed
Oct 14, 2022
| for _,itemStack in pairs(upgrades) do | ||
| local iname = itemStack:get_name() | ||
| local idef = core.registered_items[iname] | ||
| if idef.groups.drawer_public == 1 then |
There was a problem hiding this comment.
Suggested change
| if idef.groups.drawer_public == 1 then | |
| if idef and idef.groups.drawer_public == 1 then |
|
Have a look at my PR. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.