Skip to content

Commit

Permalink
leaving container-interop#65 open for discussion, bt hiding this sect…
Browse files Browse the repository at this point in the history
…ion for now
  • Loading branch information
mindplay-dk committed Jan 9, 2024
1 parent 60b1ec3 commit d799f74
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -200,15 +200,15 @@ class B implements ServiceProviderInterface
- [Twig Module](https://github.com/thecodingmachine/twig-universal-module): A service provider for the Twig templating library.
- [Whoops PSR-7 Middleware Module](https://github.com/thecodingmachine/whoops-middleware-universal-module): a service provider for the [Whoops](https://filp.github.io/whoops/) [PSR-7 middleware](https://github.com/franzliedke/whoops-middleware).

<!-- TODO resolve #65
## Best practices
### Managing configuration
The service created by a factory should only depend on the input parameters of the factory (`$container` and `$getPrevious`).
If the factory needs to fetch parameters, those should be fetched from the container directly.
TODO ^ #65

```php
class MyServiceProvider implements ServiceProviderInterface
{
Expand All @@ -231,3 +231,5 @@ class MyServiceProvider implements ServiceProviderInterface
}
}
```
-->

0 comments on commit d799f74

Please sign in to comment.