fix: resolve full screen error in key bindings and main integration #2664
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menu integration
PalmerAL
reviewed
Dec 7, 2025
| } | ||
|
|
||
| // enter full screen mode | ||
| keybindings.defineShortcut('toggleFullscreen', function () { |
Collaborator
There was a problem hiding this comment.
What does this do? I wouldn't expect this to work, since there's no toggleFullscreen defined in defaultKeyMap.
PalmerAL
reviewed
Dec 7, 2025
| })(), | ||
| click: function (item, focusedWindow) { | ||
| if (focusedWindow) { | ||
| focusedWindow.setFullScreen(!focusedWindow.isFullScreen()) |
Collaborator
There was a problem hiding this comment.
Does this produce a different result than role: 'togglefullscreen'? If it does, that's probably a bug in Electron - would you be willing to make a reduced testcase of this and open an issue there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2621
Additional key binding to full screen window.
Integrating new key binding.