Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty sparse row in importer #40585

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaofan-luan
Copy link
Collaborator

fix #40584

parquet bulk writer can not finish 0 dim sparse vector.

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 11, 2025
@sre-ci-robot sre-ci-robot requested review from sunby and xige-16 March 11, 2025 19:16
@mergify mergify bot added the dco-passed DCO check passed. label Mar 11, 2025
Copy link
Contributor

mergify bot commented Mar 11, 2025

@xiaofan-luan

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@dosubot dosubot bot added the kind/bug Issues or changes related a bug label Mar 11, 2025
@xiaofan-luan xiaofan-luan changed the title Fix empty sparse row in importer fix: empty sparse row in importer Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.18%. Comparing base (0698d04) to head (bbfe6fd).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/importutilv2/parquet/field_reader.go 94.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40585      +/-   ##
==========================================
+ Coverage   80.54%   82.18%   +1.63%     
==========================================
  Files        1474     1165     -309     
  Lines      207606   179895   -27711     
==========================================
- Hits       167223   147838   -19385     
+ Misses      34317    25993    -8324     
+ Partials     6066     6064       -2     
Components Coverage Δ
Client 79.74% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.30% <94.11%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/util/importutilv2/parquet/field_reader.go 63.33% <94.11%> (-0.16%) ⬇️

... and 346 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dosubot dosubot bot added the lgtm label Mar 12, 2025
@czs007
Copy link
Collaborator

czs007 commented Mar 12, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [czs007,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fix Empty sparse row
3 participants