Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add buffer forwarder for stream delta loading #40559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

congqixia
Copy link
Contributor

See also #40558
Related to #35303 & #38066 as well

This PR:

  • Add BufferedForward to limit memory usage forwarding stream delete
  • Add UseLoad flag to determine Delete shall use segment.Delete or segment.LoadDelta
  • Fix delegator accidentally use always true candidate while load streaming delta

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. approved area/internal-api labels Mar 11, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 11, 2025
Copy link
Contributor

mergify bot commented Mar 11, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 11, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Mar 11, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Mar 11, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 11, 2025

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 80.46875% with 25 lines in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (95e2680) to head (e17bc0a).
Report is 3 commits behind head on master.

Current head e17bc0a differs from pull request most recent head 635da26

Please upload reports for the commit 635da26 to get more accurate results.

Files with missing lines Patch % Lines
internal/querynodev2/delegator/delegator_data.go 63.33% 7 Missing and 4 partials ⚠️
...ternal/querynodev2/delegator/buffered_forwarder.go 85.71% 4 Missing and 2 partials ⚠️
internal/storage/delta_data.go 83.33% 2 Missing and 1 partial ⚠️
internal/storage/primary_keys.go 40.00% 3 Missing ⚠️
internal/querynodev2/delegator/delta_forward.go 84.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40559      +/-   ##
==========================================
- Coverage   82.14%   80.54%   -1.61%     
==========================================
  Files        1165     1475     +310     
  Lines      179900   207666   +27766     
==========================================
+ Hits       147786   167256   +19470     
- Misses      26036    34339    +8303     
+ Partials     6078     6071       -7     
Components Coverage Δ
Client 79.74% <ø> (ø)
Core 70.00% <ø> (∅)
Go 82.29% <80.46%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
...odev2/delegator/deletebuffer/list_delete_buffer.go 100.00% <100.00%> (ø)
internal/querynodev2/services.go 85.48% <100.00%> (+0.41%) ⬆️
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/delegator/delta_forward.go 68.70% <84.61%> (-0.24%) ⬇️
internal/storage/delta_data.go 98.07% <83.33%> (-1.93%) ⬇️
internal/storage/primary_keys.go 95.89% <40.00%> (-4.11%) ⬇️
...ternal/querynodev2/delegator/buffered_forwarder.go 85.71% <85.71%> (ø)
internal/querynodev2/delegator/delegator_data.go 81.52% <63.33%> (-1.23%) ⬇️

... and 338 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Mar 12, 2025

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

See also milvus-io#40558
Related to milvus-io#35303 & milvus-io#38066 as well

This PR:
- Add `BufferedForward` to limit memory usage forwarding stream delete
- Add `UseLoad` flag to determine `Delete` shall use `segment.Delete` or
  `segment.LoadDelta`
- Fix delegator accidentally use always true candidate while load
  streaming delta

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia force-pushed the enhance/buffered_forward_delta branch from e17bc0a to 635da26 Compare March 12, 2025 07:06
Copy link
Contributor

mergify bot commented Mar 12, 2025

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api component/querynode dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants