-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Add buffer forwarder for stream delta loading #40559
base: master
Are you sure you want to change the base?
enhance: Add buffer forwarder for stream delta loading #40559
Conversation
@congqixia E2e jenkins job failed, comment |
@congqixia go-sdk check failed, comment |
rerun go-sdk |
/run-cpu-e2e |
@congqixia go-sdk check failed, comment |
rerun go-sdk |
@congqixia go-sdk check failed, comment |
@congqixia cpp-unit-test check failed, comment |
rerun go-sdk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40559 +/- ##
==========================================
- Coverage 82.14% 80.54% -1.61%
==========================================
Files 1165 1475 +310
Lines 179900 207666 +27766
==========================================
+ Hits 147786 167256 +19470
- Misses 26036 34339 +8303
+ Partials 6078 6071 -7
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia E2e jenkins job failed, comment |
See also milvus-io#40558 Related to milvus-io#35303 & milvus-io#38066 as well This PR: - Add `BufferedForward` to limit memory usage forwarding stream delete - Add `UseLoad` flag to determine `Delete` shall use `segment.Delete` or `segment.LoadDelta` - Fix delegator accidentally use always true candidate while load streaming delta Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
e17bc0a
to
635da26
Compare
@congqixia go-sdk check failed, comment |
rerun go-sdk |
See also #40558
Related to #35303 & #38066 as well
This PR:
BufferedForward
to limit memory usage forwarding stream deleteUseLoad
flag to determineDelete
shall usesegment.Delete
orsegment.LoadDelta