Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Optimize datacoord meta mutex #40552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Use a separate collection mutex.
  2. Avoid holding locks for extended periods, such as in GetQuotaInfo. (TODO)

issue: #40551

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 11, 2025
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby March 11, 2025 07:02
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 11, 2025
@dosubot dosubot bot added the kind/improvement Changes related to something improve, likes ut and code refactor label Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 7 lines in your changes missing coverage. Please review.

Project coverage is 80.52%. Comparing base (3899b0f) to head (c74b558).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/meta.go 93.25% 6 Missing ⚠️
internal/datacoord/services.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40552      +/-   ##
==========================================
- Coverage   82.19%   80.52%   -1.67%     
==========================================
  Files        1165     1474     +309     
  Lines      179833   207607   +27774     
==========================================
+ Hits       147817   167183   +19366     
- Misses      25965    34348    +8383     
- Partials     6051     6076      +25     
Components Coverage Δ
Client 79.74% <ø> (ø)
Core 70.00% <ø> (∅)
Go 82.27% <92.30%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/services.go 84.16% <50.00%> (ø)
internal/datacoord/meta.go 89.09% <93.25%> (+<0.01%) ⬆️

... and 342 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 11, 2025
@bigsheeper
Copy link
Contributor Author

related to #37630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants