Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix null offset loading in inverted index #40524

Open
wants to merge 3 commits into
base: 2.5
Choose a base branch
from

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Mar 10, 2025

issue: #40516
pr: #40523

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 10, 2025
liliuleo

This comment was marked as outdated.

@sre-ci-robot
Copy link
Contributor

@liliuleo: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

mergify bot commented Mar 10, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Mar 10, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 78.57143% with 9 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (004668b) to head (1ad260b).

Files with missing lines Patch % Lines
internal/core/src/index/InvertedIndexTantivy.cpp 78.04% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40524      +/-   ##
==========================================
+ Coverage   80.91%   80.93%   +0.02%     
==========================================
  Files        1421     1421              
  Lines      200844   200856      +12     
==========================================
+ Hits       162513   162563      +50     
+ Misses      32639    32611      -28     
+ Partials     5692     5682      -10     
Components Coverage Δ
Client 79.77% <ø> (ø)
Core 70.34% <78.57%> (-0.02%) ⬇️
Go 82.82% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Array.h 92.36% <100.00%> (ø)
internal/core/src/index/InvertedIndexTantivy.cpp 85.06% <78.04%> (-1.97%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaofan-luan xiaofan-luan added this to the 2.5.6 milestone Mar 11, 2025
@sunby sunby force-pushed the fix_null_inverted_index_2.5 branch from 679b024 to 1ad260b Compare March 11, 2025 02:24
Copy link
Contributor

mergify bot commented Mar 11, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, liliuleo, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sunby
Copy link
Contributor Author

sunby commented Mar 11, 2025

/run-cpu-e2e

1 similar comment
@yanliang567
Copy link
Contributor

/run-cpu-e2e

@yanliang567 yanliang567 modified the milestones: 2.5.6, 2.5.7 Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants